Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customized Welcome After Pages and Conclusion Pages #590

Merged
merged 39 commits into from
Jan 11, 2023
Merged

Customized Welcome After Pages and Conclusion Pages #590

merged 39 commits into from
Jan 11, 2023

Commits on Dec 6, 2022

  1. Adding in an example folder for custom welcome and conclusion for Win… 

    …dows.
    @ryanskeith
    ryanskeith committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    188ce66 View commit details
    Browse the repository at this point in the history

  2. Adding in documentation for changes for Windows for the welcome and c… 

    …onclusion files.
    @ryanskeith
    ryanskeith committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    6646ccb View commit details
    Browse the repository at this point in the history

  3. Adding in some changes.

    @ryanskeith
    ryanskeith committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    070e13f View commit details
    Browse the repository at this point in the history

  4. Adding in example image.

    @ryanskeith
    ryanskeith committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    fdc8ee3 View commit details
    Browse the repository at this point in the history

  5. Adding in custom welome and conclusion file code.

    @ryanskeith
    ryanskeith committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    50415c3 View commit details
    Browse the repository at this point in the history

  6. Adding in code to add in extra resources for extra pages.

    @ryanskeith
    ryanskeith committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    6b45c6c View commit details
    Browse the repository at this point in the history

  7. Fixing an error with the nsis script.

    @ryanskeith
    ryanskeith committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    6343f9f View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. Adding functionality for extra pages after welcome.

    @ryanskeith
    ryanskeith committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    4ed5eb6 View commit details
    Browse the repository at this point in the history

  2. fixing name collision.

    @ryanskeith
    ryanskeith committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    02917f3 View commit details
    Browse the repository at this point in the history

  3. Adding in news information about enhancement.

    @ryanskeith
    ryanskeith committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    c380ebb View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Merge branch 'main' into customize_welcome_conclusion

    @jaimergp
    jaimergp committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    3f77efc View commit details
    Browse the repository at this point in the history

  2. Update CONSTRUCT.md via python ./scripts/make_docs.py

    @dbast
    dbast committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    3757f0e View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. Merge branch 'main' into customize_welcome_conclusion

    @dbast
    dbast committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    07f7f13 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Giving a warning if OSX packager sees an nsi file in the conclusion o… 

    …r welcome page.
    @ryanskeith
    ryanskeith committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    86d8023 View commit details
    Browse the repository at this point in the history

  2. Update constructor/nsis/main.nsi.tmpl 

    Co-authored-by: Jaime Rodríguez-Guerra <jaimergp@users.noreply.github.com>
    @ryanskeith @jaimergp
    ryanskeith and jaimergp committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    0b49590 View commit details
    Browse the repository at this point in the history

  3. Spelling changes.

    @ryanskeith
    ryanskeith committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    cfd4ac5 View commit details
    Browse the repository at this point in the history

  4. Adding custom_welcome and custome_conclusion to ppd dict.

    @ryanskeith
    ryanskeith committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    0d8ac9c View commit details
    Browse the repository at this point in the history

  5. Update constructor/nsis/main.nsi.tmpl 

    Adding in custom conclusion logic.

Co-authored-by: Jaime Rodríguez-Guerra <jaimergp@users.noreply.github.com>
    @ryanskeith @jaimergp
    ryanskeith and jaimergp committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    cb8df27 View commit details
    Browse the repository at this point in the history

  6. Removing code line for custom dir.

    @ryanskeith
    ryanskeith committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    a1735c4 View commit details
    Browse the repository at this point in the history

  7. extra_files items need to be in list form in yaml.

    @ryanskeith
    ryanskeith committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    60fbccb View commit details
    Browse the repository at this point in the history

  8. Fixing examples files because they need to define MUI_PAGE_WELOME and… 

    … MUI_PAGE_FINISH.
    @ryanskeith
    ryanskeith committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    0fe9459 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Cleaning out last of extra files to plugins stuff.

    @ryanskeith
    ryanskeith committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    7287edc View commit details
    Browse the repository at this point in the history

  2. Update constructor/winexe.py 

    Co-authored-by: Jaime Rodríguez-Guerra <jaimergp@users.noreply.github.com>
    @ryanskeith @jaimergp
    ryanskeith and jaimergp committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    f2ebebc View commit details
    Browse the repository at this point in the history

  3. Update constructor/osxpkg.py 

    Co-authored-by: Jaime Rodríguez-Guerra <jaimergp@users.noreply.github.com>
    @ryanskeith @jaimergp
    ryanskeith and jaimergp committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    65f40eb View commit details
    Browse the repository at this point in the history

  4. Succinct code and adding Warning for consistency.

    @ryanskeith
    ryanskeith committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    431571a View commit details
    Browse the repository at this point in the history

  5. Adding in extra temp file functionality.

    @ryanskeith
    ryanskeith committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    a02d21a View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Changing how copy_extra_files works so temp_extra_files can use it too.

    @ryanskeith
    ryanskeith committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    1d4bd43 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. Merge branch 'main' into customize_welcome_conclusion

    @dbast
    dbast committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    30cfee4 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. Update news/590-windows-installer-enhancement 

    Co-authored-by: Jaime Rodríguez-Guerra <jaimergp@users.noreply.github.com>
    @ryanskeith @jaimergp
    ryanskeith and jaimergp committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    a13c3de View commit details
    Browse the repository at this point in the history

  2. Update constructor/osxpkg.py 

    Co-authored-by: Jaime Rodríguez-Guerra <jaimergp@users.noreply.github.com>
    @ryanskeith @jaimergp
    ryanskeith and jaimergp committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    3d0d3bb View commit details
    Browse the repository at this point in the history

  3. Merge branch 'temporary_extra_files' into customize_welcome_conclusion

    @ryanskeith
    ryanskeith committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    b5f0b86 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. Add missing comma

    @dbast
    dbast committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    36bca48 View commit details
    Browse the repository at this point in the history

  2. Fixing docs.

    @ryanskeith
    ryanskeith committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    21aa838 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. Update examples/customized_welcome_conclusion/construct.yaml 

    Co-authored-by: Jaime Rodríguez-Guerra <jaimergp@users.noreply.github.com>
    @ryanskeith @jaimergp
    ryanskeith and jaimergp committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    66eeb31 View commit details
    Browse the repository at this point in the history

  2. Update news/590-windows-installer-enhancement 

    Co-authored-by: Jaime Rodríguez-Guerra <jaimergp@users.noreply.github.com>
    @ryanskeith @jaimergp
    ryanskeith and jaimergp committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    e148b6a View commit details
    Browse the repository at this point in the history

  3. Update constructor/winexe.py 

    Co-authored-by: Jaime Rodríguez-Guerra <jaimergp@users.noreply.github.com>
    @ryanskeith @jaimergp
    ryanskeith and jaimergp committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    7cceea5 View commit details
    Browse the repository at this point in the history

  4. Adding in comments to explain example custom pages.

    @ryanskeith
    ryanskeith committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    cae3969 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. Merge branch 'main' into customize_welcome_conclusion

    @jaimergp
    jaimergp committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    b173e0f View commit details
    Browse the repository at this point in the history

  2. doc update

    @dbast
    dbast committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    ac4b1b5 View commit details
    Browse the repository at this point in the history