Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for micromamba, transmutation and miniforge (continued) #605

Merged
merged 29 commits into from Jan 16, 2023

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Jan 11, 2023

Description

Continues and closes #503

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 11, 2023
@jaimergp
Copy link
Contributor Author

@chrisburr Is mamba-org/mamba#1497 behind the errors with micromamba+miniforge+transmutation?

@dbast dbast mentioned this pull request Jan 12, 2023
3 tasks
@jaimergp
Copy link
Contributor Author

Two bugs surfacing if micromamba is used:

  • .conda transmutation
  • Shortcuts not being created on Windows (need to investigate on VM to know what's going on).

@chrisburr
Copy link
Contributor

@chrisburr Is mamba-org/mamba#1497 behind the errors with micromamba+miniforge+transmutation?

I don't think so. The errors are different and I've been using transmutation+micromamba without any issues.

@jaimergp
Copy link
Contributor Author

Got it, thanks! I'll need to investigate locally 👷

@jaimergp
Copy link
Contributor Author

Ok, the "only" bug left now is Windows+micromamba+shortcuts. TBD.

@jaimergp
Copy link
Contributor Author

More details about the errors:

Creating Miniforge3 menus...
The following argument was not expected: --make-menus
Run with --help for more information.
::error:: Failed to create menus

micromamba does not seem to support creating menus directly.

% micromamba.exe constructor [OPTIONS]

Options:
  -h,--help                   Print this help message and exit
  -p,--prefix TEXT            Extract the conda pkgs in <prefix>/pkgs
  --extract-conda-pkgs        Extract the conda pkgs in <prefix>/pkgs
  --extract-tarball           Extract given tarball into prefix

So we can't really test this for now. We could implement a fallback strategy via the bundled Python in base + _nsis.py integrations, but I don't want to add more coupling between the installer logic and the installer contents.

conda-forge is not using micromamba for Windows as far as I can see, so this is not critical. I'll add some documentation so people know what to expect.

@dbast
Copy link
Member

dbast commented Jan 15, 2023

Looks pretty good. Is the PR still in draft state or ready for review?

@jaimergp
Copy link
Contributor Author

Yes I'll remove the draft status as soon as all is green. Hopefully this commit?

@jaimergp jaimergp marked this pull request as ready for review January 16, 2023 09:20
@jaimergp jaimergp requested a review from a team as a code owner January 16, 2023 09:20
dbast
dbast previously approved these changes Jan 16, 2023
@jaimergp
Copy link
Contributor Author

Last minute change :D Turns out --make-menus is always used on Windows, so all installers will fail there. We can change that in a future PR, but for now we'll error out if micromamba & windows are used together.

@chrisburr
Copy link
Contributor

Last minute change :D Turns out --make-menus is always used on Windows, so all installers will fail there. We can change that in a future PR, but for now we'll error out if micromamba & windows are used together.

It's probably better to fix this on the mamba side: mamba-org/mamba#1215

@jaimergp
Copy link
Contributor Author

Agreed!

@jaimergp jaimergp merged commit 53be6d8 into conda:main Jan 16, 2023
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jan 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants