Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to provide defaults for custom options #68

Merged
merged 1 commit into from
Aug 23, 2017

Conversation

mbargull
Copy link
Member

@mbargull mbargull commented Mar 2, 2017

This adds to new keys (add_to_path_default, register_python_default) with which the installer's custom options can be given explicit default values in construct.yaml. Useful if one wants to create an installer which, by default, does not interfere with the system (i.e. both values set to False).

@astaric
Copy link
Contributor

astaric commented Mar 23, 2017

@ilanschnell is this change something that could be included in constructor?

I am currently trying to build win installer for a package that installs its own menu shortcuts and thus does not need to change default path. Personally, I would not mind setting the defaults and not showing the choice screen to users at all, but providing different defaults is a good start.

@msarahan
Copy link
Contributor

Thanks for this helpful change, @mbargull. Merging.

@msarahan msarahan merged commit 0b82396 into conda:master Aug 23, 2017
@github-actions
Copy link

Hi there, thank you for your contribution!

This pull request has been automatically locked because it has not had recent activity after being closed.

Please open a new issue or pull request if needed.

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Mar 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants