Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove menus of all conda envs during uninstall #75

Merged
merged 1 commit into from
Aug 23, 2017

Conversation

mbargull
Copy link
Member

@mbargull mbargull commented May 2, 2017

This makes the uninstaller remove not only the root environment's menus but also the menus from all other environments (if possible).
It tries to get the list of environments via the conda.cli.python_api.
An alternative implementation is provided, which uses libconda.config.envs_dirs and code copied from conda.misc.list_prefixes to get the list of environments. Since conda.misc.list_prefixes should be considered internal/subject to change, I feel more comfortable using conda.cli.python_api instead, which is thus the active implementation in this PR.

Use case:
An user creates new environments with packages containing menuinst menus. The user then uninstalls the whole constructor-created installation without explicitly removing those environments beforehand. Prior to this PR the menu entries created for packages outside the root environment would persist after the uninstallation.

@msarahan
Copy link
Contributor

Thanks for this helpful change, @mbargull. Merging.

@msarahan msarahan merged commit 2c3f866 into conda:master Aug 23, 2017
@github-actions
Copy link

Hi there, thank you for your contribution!

This pull request has been automatically locked because it has not had recent activity after being closed.

Please open a new issue or pull request if needed.

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Mar 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants