Add step to file issues if tests fails after merging to main #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
jaimergp
reviewed
Apr 23, 2024
| @@ -145,6 +145,16 @@ jobs: | |||
| run: | | |||
| python scripts/make_docs.py | |||
| git diff --exit-code | |||
| - name: Report failures | |||
| if: always() && github.event_name == 'push' | |||
There was a problem hiding this comment.
This should only run on main, in case we have push events to a branch for a PR. But we are only allowing this event on main and tags, so we are fine.
jaimergp
approved these changes
Apr 23, 2024
marcoesters
deleted the
775-automatically-create-issue-on-test-failure-after-merging-to-main
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding integration tests for AzureSignTool (#771) requires access to repository secrets. These are not available when submitting a PR from a fork. Tests must then be executed after merging to
main. This risks that errors are not caught.To increase visibility of these problems, create an issue when tests fail after being merged into
main.Closes #775.
Token has been added to the repo: conda/infrastructure#920
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?