Apply suggestions from code review

Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
conda · Apr 23, 2024 · 1909ef0 · 1909ef0
1 parent 1de5f43
commit 1909ef0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/menuinst/_schema.py b/menuinst/_schema.py
@@ -39,7 +39,7 @@ class BasePlatformSpecific(BaseModel):
     name: Optional[
         Union[
             constr(min_length=1),
-            Dict[constr(regex=r"^target_environment_is(_not)?_base$"), constr(min_length=1)],
+            Dict[Literal["target_environment_is_base", "target_environment_is_not_base"], constr(min_length=1)],
         ]
     ] = None
     """

diff --git a/news/180-support-different-names-outside-base b/news/180-support-different-names-outside-base
@@ -1,6 +1,6 @@
 ### Enhancements
 
-* Support different name for shortcuts within and outside base environment (support v1 behavior)
+* Support different name for shortcuts within and outside base environment (support v1 behavior). (#180)
 
 ### Bug fixes