Fix Windows registry access mode when adding icons to file type assoc…

…iations (#206) * Open icon subkey with write access * Add icon to file_types test file * Add news item * Add icon only to Windows tests * Remove accidental tab * Update tests/data/jsons/file_types.json Co-authored-by: jaimergp <jaimergp@users.noreply.github.com> --------- Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
conda · May 10, 2024 · 2416e74 · 2416e74
1 parent fc5d064
commit 2416e74
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/menuinst/platforms/win_utils/registry.py b/menuinst/platforms/win_utils/registry.py
@@ -72,7 +72,7 @@ def register_file_extension(extension, identifier, command, icon=None, mode="use
         log.debug("Created registry entry for command '%s'", command)
 
         if icon:
-            subkey = winreg.OpenKey(key, identifier)
+            subkey = winreg.OpenKey(key, identifier, access=winreg.KEY_SET_VALUE)
             winreg.SetValueEx(subkey, "DefaultIcon", 0, winreg.REG_SZ, icon)
             log.debug("Created registry entry for icon '%s'", icon)
 

diff --git a/news/206-file-extensions-regkey-access b/news/206-file-extensions-regkey-access
@@ -0,0 +1,19 @@
+### Enhancements
+
+* <news item>
+
+### Bug fixes
+
+* Fix Windows registry key access mode when adding icon file to file type association. (#191 via #206)
+
+### Deprecations
+
+* <news item>
+
+### Docs
+
+* <news item>
+
+### Other
+
+* <news item>
diff --git a/tests/data/jsons/file_types.json b/tests/data/jsons/file_types.json
@@ -14,6 +14,7 @@
             ],
             "platforms": {
                 "win": {
+                    "icon": "doesnotexistbutitsok.{{ ICON_EXT }}",
                     "command": [
                         "{{ PYTHON }}",
                         "-c",