Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve errors and warnings when shortcuts already exist #205

Merged
merged 16 commits into from
May 20, 2024
Merged

Improve errors and warnings when shortcuts already exist #205

merged 16 commits into from
May 20, 2024

Commits on May 7, 2024

  1. Overwrite existing app on MacOS

    @marcoesters
    marcoesters committed May 7, 2024
    Configuration menu
    Copy the full SHA
    4fea9d4 View commit details
    Browse the repository at this point in the history

  2. Warn when shortcuts are overwritten

    @marcoesters
    marcoesters committed May 7, 2024
    Configuration menu
    Copy the full SHA
    fe57f89 View commit details
    Browse the repository at this point in the history

  3. Add tests

    @marcoesters
    marcoesters committed May 7, 2024
    Configuration menu
    Copy the full SHA
    c8e745e View commit details
    Browse the repository at this point in the history

  4. Add news item

    @marcoesters
    marcoesters committed May 7, 2024
    Configuration menu
    Copy the full SHA
    8fe150e View commit details
    Browse the repository at this point in the history

  5. Convert target_path to Path object

    @marcoesters
    marcoesters committed May 7, 2024
    Configuration menu
    Copy the full SHA
    6344ee5 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Check if file exists before deleting after tests to account for dupli… 

    …cates
    @marcoesters
    marcoesters committed May 8, 2024
    Configuration menu
    Copy the full SHA
    c4ee347 View commit details
    Browse the repository at this point in the history

  2. Use correct path for Windows

    @marcoesters
    marcoesters committed May 8, 2024
    Configuration menu
    Copy the full SHA
    12bba6c View commit details
    Browse the repository at this point in the history

  3. Capture and test warnings for overwrite test

    @marcoesters
    marcoesters committed May 8, 2024
    Configuration menu
    Copy the full SHA
    adeb16f View commit details
    Browse the repository at this point in the history

  4. Replace deprecated warn method with warning

    @marcoesters
    marcoesters committed May 8, 2024
    Configuration menu
    Copy the full SHA
    2f7cae3 View commit details
    Browse the repository at this point in the history

  5. Use test file without placeholders in name

    @marcoesters
    marcoesters committed May 8, 2024
    Configuration menu
    Copy the full SHA
    017f5b2 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Merge branch 'main' into osx-app-overwrite

    @marcoesters
    marcoesters committed May 9, 2024
    Configuration menu
    Copy the full SHA
    aef7842 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Raise RuntimeError when overwriting MacOS apps

    @marcoesters
    marcoesters committed May 14, 2024
    Configuration menu
    Copy the full SHA
    614d25e View commit details
    Browse the repository at this point in the history

  2. Update news item

    @marcoesters
    marcoesters committed May 14, 2024
    Configuration menu
    Copy the full SHA
    677c0af View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Apply suggestions from code review 

    Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
    @marcoesters @jaimergp
    marcoesters and jaimergp committed May 15, 2024
    Configuration menu
    Copy the full SHA
    0314f61 View commit details
    Browse the repository at this point in the history

  2. Adjust warning text in docs to describe that MacOS apps will not be o… 

    …verwritten
    @marcoesters
    marcoesters committed May 15, 2024
    Configuration menu
    Copy the full SHA
    1ba8600 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Merge branch 'main' into osx-app-overwrite

    @marcoesters
    marcoesters committed May 16, 2024
    Configuration menu
    Copy the full SHA
    d471689 View commit details
    Browse the repository at this point in the history