Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite for cross-platform compatibility (following conda/ceps#8) #91

Merged
merged 214 commits into from
Jan 12, 2023

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Nov 3, 2021

CEP: conda/ceps#8

To do

  • Create new project scaffold and move old code to _legacy
  • Create JSON-Schema for the input files
  • Implement shortcut creation for Windows
  • Implement shortcut creation for Linux
  • Implement shortcut creation for MacOS
  • Implement environment activation on Unix
  • Implement environment activation on Windows
  • Cleanup tasks: conda [env] remove should also delete created menu items
  • Do not depend on pydantic at runtime
  • Implement superuser elevation on Windows
  • Implement superuser elevation on Linux (?)
  • Implement superuser elevation on MacOS (?)
  • Test elevation
  • Handle interference of PYTHON* variables with shortcuts
  • macOS integrations: entitlements and permissions
  • macOS integrations: keyboard shortcuts registration
  • Clean up unused code
  • Sort common Windows utilities

@jaimergp jaimergp requested a review from a team as a code owner November 3, 2021 14:00
@jaimergp jaimergp marked this pull request as draft November 3, 2021 14:00
@hoechenberger
Copy link

Wow. All but one checkboxes of the todo are ticked ✅ Does this mean this work is almost done? 😲😎

@jaimergp
Copy link
Contributor Author

jaimergp commented Dec 8, 2022

Not yet, I am debugging some elevation stuff I am not happy with, and we also got a report where PYTHON* variables disrupt the launch of the program.

But it's getting closer :)

@hoechenberger
Copy link

Nice, thanks for the hard work!!

@jaimergp
Copy link
Contributor Author

@conda/constructor - how do you feel about merging this to a feature branch to keep further iterations well isolated?

@jezdez
Copy link
Member

jezdez commented Jan 3, 2023

@jaimergp +1

For sanity reasons, I would also suggest polishing the CEP and get it voted on ASAP.

@jaimergp jaimergp changed the base branch from main to cep-devel January 12, 2023 22:50
@jaimergp
Copy link
Contributor Author

Updated the target branch and merging.

@jaimergp jaimergp marked this pull request as ready for review January 12, 2023 22:51
@jaimergp jaimergp merged commit 81af647 into conda:cep-devel Jan 12, 2023
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jan 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Rework linux/osx support plus new simplified format?
4 participants