Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed a memory leak. #38

Closed
wants to merge 2 commits into from
Closed

fixed a memory leak. #38

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e1ff40
fixed a memory leak.
Kray-G Mar 19, 2021
52849ac
Merge branch 'conda:master' into master
Kray-G Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 7 additions & 7 deletions pycosat.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,23 +66,23 @@ inline static void py_free(void *mmgr, void *ptr, size_t bytes)
/* Add the inverse of the (current) solution to the clauses.
This function is essentially the same as the function blocksol in app.c
in the picosat source. */
static int blocksol(PicoSAT *picosat, signed char *mem)
static int blocksol(PicoSAT *picosat, signed char **mem)
{
int max_idx, i;

max_idx = picosat_variables(picosat);
if (mem == NULL) {
mem = PyMem_Malloc(max_idx + 1);
if (mem == NULL) {
if (*mem == NULL) {
*mem = PyMem_Malloc(max_idx + 1);
if (*mem == NULL) {
PyErr_NoMemory();
return -1;
}
}
for (i = 1; i <= max_idx; i++)
mem[i] = (picosat_deref(picosat, i) > 0) ? 1 : -1;
(*mem)[i] = (picosat_deref(picosat, i) > 0) ? 1 : -1;

for (i = 1; i <= max_idx; i++)
picosat_add(picosat, (mem[i] < 0) ? i : -i);
picosat_add(picosat, ((*mem)[i] < 0) ? i : -i);

picosat_add(picosat, 0);
return 0;
Expand Down Expand Up @@ -303,7 +303,7 @@ static PyObject* soliter_next(soliterobject *it)
return NULL;
}
/* add inverse solution to the clauses, for next iteration */
if (blocksol(it->picosat, it->mem) < 0)
if (blocksol(it->picosat, &it->mem) < 0)
return NULL;
break;

Expand Down