Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds a
minimal
keyword argument, which optimizes PicoSat for finding minimal solutionsMotivation
In many practical applications the literals are control flags. Due to the risk of unforeseen consequences in the presence of unnecessary changes, it is beneficial to minimize them.
Changes
minimal=False
the code runs exactly as before.minimal=True
:Usage example
This imediately returns a solution with only 500 positive values, which is the least number needed for it to be true. The current implementation returns all variables set to True (i.e. all positive)