Teach (iter)solve to take generic iterables of iterables as clauses argument #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clauses This reduces code redundancy in pycosat.c's add_clauses function.
According to the CPython API, PyObject_GetIter sets a TypeError without needing it to be set again by the calling code.
Commit fdf54a8 taught them to accept the list of lists that represented clauses as any iterable of lists. Now it can be any iterable of any iterables.
ilanschnell
added a commit
that referenced
this pull request
Nov 10, 2013
Teach (iter)solve to take generic iterables of iterables as clauses argument
|
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, you could call
solve(anditersolveimplied bysolvefrom here on out) only with a list of lists of ints. Alternatively you could callsolvewith an iterator of lists of ints. This pull request adds the ability to callsolvewith a generic iterable of iterables of ints, for example a tuple of generators of ints.Tests for both
solveanditersolvepass on Pythons 3.3.2 and 2.7.5 (using the patch from #5) on Mac OS with compiler Apple LLVM version 4.2 (clang-425.0.28) (based on LLVM 3.2svn) targeting x86_64-apple-darwin12.5.0. I don't have access to Windows or Linux.This addresses issue #3.