support Python 2.7, 3.7-3.11 in setup.py #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
dholth
commented
Oct 25, 2022
| include \ | ||
| setup.h CHANGELOG CODE_OF_CONDUCT.md HOW_WE_USE_GITHUB.md LICENSE \ | ||
| Makefile README.rst picosat.c picosat.h pycosat.c test_pycosat.py | ||
| graft examples/ |
There was a problem hiding this comment.
basically git ls-files
Otherwise it doesn't include picosat.c and picosat.h, necessary to compile the extension.
dholth
commented
Nov 4, 2022
| "Programming Language :: Python :: 3.8", | ||
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", |
There was a problem hiding this comment.
Should we give up and just say Python :: 3 and requires-python > 3.7
mcg1969
approved these changes
Nov 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why not declare support for new Pythons.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?