Postgres locking DAO #102
Merged
Postgres locking DAO #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerstraeteBert
force-pushed
the
pg-locking
branch
from
65f43d4
to
5d7697e
Compare
bjpirt
approved these changes
Mar 7, 2024
postgres-persistence/src/main/resources/db/migration_postgres/V9__locking.sql
Outdated
Show resolved
Hide resolved
postgres-persistence/src/main/java/com/netflix/conductor/postgres/dao/PostgresLockDAO.java
Outdated
Show resolved
Hide resolved
|
@VerstraeteBert Looks like the build is failing because there's already a V9 migration - renaming to V11 should do it |
bjpirt
approved these changes
Mar 17, 2024
bjpirt
approved these changes
Mar 18, 2024
vincent-cognite
approved these changes
Mar 25, 2024
v1r3n
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
Implement Postgres locking DAO
Fixes the issues observed in #81
A remaining issue is the fact that lock leases may not cover the full time the thread want to hold the lock is covered (e.g., long GCs, ...), this issue is present in the Redis lock implementation as well and would be solved the alternative outlined below.
Alternatives considered
Postgres has row level and table level locks, in addition to application-defined locks through advisory locking. Both of these are on the transaction level, which does not work with the current architecture of Conductor as transaction are handled at the lowest level (i.e., per database operation). To allow this to work, a larger overhaul is required where transaction are managed at the service level.