Fix of exception handler trying to write response to a disconnected c… #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lient Why: On Conductor server side, an exception gets raised `Failure in @ExceptionHandler com.netflix.conductor.rest.controllers.ApplicationExceptionMapper#handleAll(HttpServletRequest, Throwable)`. Cause is attempting to write while the client aborted the connection `org.apache.catalina.connector.ClientAbortException: java.io.IOException: Broken pipe` What: Added a ClientAbortException handler. Testing done: Local run. Not trivial to emulate the issue in a test. Such a test may rely on timing out the client before server responded. Signed-off-by: Iva Avramova <ikoleva@vmware.com>
saksham2105
reviewed
Apr 3, 2024
| @@ -53,7 +53,16 @@ public class ApplicationExceptionMapper { | |||
| EXCEPTION_STATUS_MAP.put(NoResourceFoundException.class, HttpStatus.NOT_FOUND); | |||
| } | |||
|
|
|||
| @ExceptionHandler(ClientAbortException.class) | |||
There was a problem hiding this comment.
Please check the build failure, Probably a testcase is failing
v1r3n
approved these changes
Apr 3, 2024
|
Hi @ivakoleva , Do we need this change? Since the exception is clear on the client side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lient
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
On Conductor server side, an exception gets raised
Failure in @ExceptionHandler com.netflix.conductor.rest.controllers.ApplicationExceptionMapper#handleAll(HttpServletRequest, Throwable). Cause is - attempting to write while the client aborted the connectionorg.apache.catalina.connector.ClientAbortException: java.io.IOException: Broken pipeAdded a ClientAbortException handler.
Testing done: Local run. Not trivial to emulate the issue in a test. Such a test may rely on timing out the client before server responded.
Alternatives considered