Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow bulk deletion API and action module options #110

Merged
merged 10 commits into from
Apr 3, 2024

Conversation

olibaim
Copy link
Contributor

@olibaim olibaim commented Mar 24, 2024

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • WHOSUSING.md
  • Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

Describe the new behavior from this PR, and why it's needed

  • Added API for bulk workflow deletion, removes workflows from server and returns status 200 upon success
  • Archive option archives instead of delete
  • Added 'Delete' and 'Archive' options to UI in Bulk Action Module
  • Allows management of unnecessary and irrelevant workflows

Pre deletion of two completed workflows, showing 'Delete' and 'Archive' additions to bulk action module dropdown
image

Batch action module popup after aforementioned workflows are deleted
image

Updated workflows table after successful deletion
image

Alternatives considered

Describe alternative implementation you have considered

Additional/future considerations

  • Currently, deleting a running workflow is not possible. Addition of bulk terminate-delete API to solve this is in process Bulk terminate-delete API method has been added
  • Unit testing

@olibaim olibaim marked this pull request as draft April 1, 2024 03:37
@olibaim olibaim marked this pull request as ready for review April 1, 2024 19:17
olibaim and others added 2 commits April 3, 2024 03:33
#10)

* Fixed WorkflowBulkServiceTest, added test cases for deleteWorkflow and terminateRemove, and added WorkflowResourceTest test for single terminateRemove

* pass spotlessjava

---------

Co-authored-by: JeffP <jeffp@jeffpham.com>
@v1r3n v1r3n merged commit ff040fe into conductor-oss:main Apr 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants