Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conductor-oss-fixDynamicForkIssue: Sync FORK_JOIN_DYNAMIC with Enterprise Version #19

Merged

Conversation

saksham2105
Copy link
Contributor

@saksham2105 saksham2105 commented Dec 20, 2023

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes (Please run ./gradlew generateLock saveLock to refresh dependencies)
  • WHOSUSING.md
  • Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

Describe the new behavior from this PR, and why it's needed
Issue # Details of issue mentioned here

What does this PR address :- To execute single task or subworkflow with an array of inputs inside DynamicForkJoin which currently gives (Input to the dynamically forked tasks is not a map -> expecting a map of k,v but found null) in oss versions while execution of DynamicForkJoin task

This will Sync with what happens for DynamicForkJoin in Orkes Version

Alternatives considered

Describe alternative implementation you have considered

Working POC :-

Screenshot 2023-12-20 at 6 05 27 PM

@saksham2105 saksham2105 changed the title conductor-oss-fixDynamicForkIssue: Fix for dynamic fork issue conductor-oss-fixDynamicForkIssue: Sync DynamicForkJoin in conductor-oss with Orkes Versions Dec 20, 2023
@saksham2105 saksham2105 changed the title conductor-oss-fixDynamicForkIssue: Sync DynamicForkJoin in conductor-oss with Orkes Versions conductor-oss-fixDynamicForkIssue: Sync DynamicForkJoin in conductor-oss with Orkes Version Dec 20, 2023
@saksham2105 saksham2105 changed the title conductor-oss-fixDynamicForkIssue: Sync DynamicForkJoin in conductor-oss with Orkes Version conductor-oss-fixDynamicForkIssue: Sync FORK_JOIN_DYNAMIC in OSS with Orkes Version Dec 20, 2023
@saksham2105 saksham2105 changed the title conductor-oss-fixDynamicForkIssue: Sync FORK_JOIN_DYNAMIC in OSS with Orkes Version conductor-oss-fixDynamicForkIssue: Sync FORK_JOIN_DYNAMIC with Orkes Version Dec 20, 2023
@saksham2105 saksham2105 changed the title conductor-oss-fixDynamicForkIssue: Sync FORK_JOIN_DYNAMIC with Orkes Version conductor-oss-fixDynamicForkIssue: Sync FORK_JOIN_DYNAMIC with Enterprise Version Dec 20, 2023
@meggarr
Copy link
Contributor

meggarr commented Dec 21, 2023

Hi @saksham2105 , shall the OSS document be updated to address this change ?

@saksham2105
Copy link
Contributor Author

saksham2105 commented Dec 21, 2023

Hey @meggarr I will update the changes in Doc in some time

@saksham2105 saksham2105 force-pushed the conductor-oss-fixDynamicForkIssue branch from 037dd1e to 3896ef2 Compare December 22, 2023 07:13
@v1r3n v1r3n merged commit fec3116 into conductor-oss:main Dec 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants