Add option to only index workflows on Postgres when their status changes #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjpirt
force-pushed
the
index-on-status-change
branch
2 times, most recently
from
1cf6022
to
9fbcb9a
Compare
bjpirt
force-pushed
the
index-on-status-change
branch
from
9fbcb9a
to
c4fc9c6
Compare
v1r3n
approved these changes
Mar 5, 2024
bjpirt
force-pushed
the
index-on-status-change
branch
from
c4fc9c6
to
939eaeb
Compare
bjpirt
force-pushed
the
index-on-status-change
branch
from
939eaeb
to
e99bebc
Compare
matiasbur
pushed a commit
to preqin/conductor
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
Currently the Postgres IndexDAO will index every change to a workflow and task. However if you're only really using the index so that you can find things in the UI, then this might be excessive.
This option allows you to choose to only index the workflows and tasks when they change status.
Pros and Cons