BugFix: Enable the migration to run without always recreating an index #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjpirt
force-pushed
the
fix-index-migration
branch
from
0406990
to
6462251
Compare
bjpirt
changed the title
v1r3n
approved these changes
Mar 4, 2024
denniscodes
pushed a commit
to denniscodes-oss/conductor
that referenced
this pull request
Mar 5, 2024
matiasbur
pushed a commit
to preqin/conductor
that referenced
this pull request
May 3, 2024
matiasbur
pushed a commit
to preqin/conductor
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
This PR got merged before I'd had chance to check how the migration worked in a full database - there was an issue in that it was dropping an index and then recreating it. In a table with lots of records this can take too long to run and in our case was causing the Conductor instances to be marked as unhealthy and restarted.
By using a different name for the index, it is possible to make the changes manually if you have lots of data in your table and then when you deploy the migration will be instantaneous because of
IF NOT EXISTS