Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Implement workers as functions #106

Merged
merged 41 commits into from
Jul 25, 2022
Merged

[feature] Implement workers as functions #106

merged 41 commits into from
Jul 25, 2022

Conversation

gardusig
Copy link
Contributor

@gardusig gardusig commented Jul 14, 2022 •
edited
Loading

Changes:

  • Removed older unused TaskWorker class
  • Created a new Worker class
    • Provides easier onboarding for implementing a worker
  • Fixed bug when polling for task
    • Exception was raised when polling for an empty queue
  • Improved worker documentation
  • Added a new GitHub Action event which triggers on pull requests, steps:
    • required
      • unit tests
      • integration tests
    • not required
      • linter
  • Removed /src/example, relevant data got moved to tests/

@gardusig gardusig self-assigned this Jul 14, 2022
@gardusig gardusig linked an issue Jul 14, 2022 that may be closed by this pull request
Improve Worker definition #102
Closed
@gardusig gardusig requested a review from v1r3n July 14, 2022 01:37
@gardusig gardusig marked this pull request as ready for review July 14, 2022 01:38
This was linked to issues Jul 19, 2022
Add support for Worker with generic output #104
Closed
Add support for Worker with generic input #103
Closed
@gardusig gardusig linked an issue Jul 20, 2022 that may be closed by this pull request
Create new GitHub Action event on pull request #5
Closed
@gardusig gardusig linked an issue Jul 21, 2022 that may be closed by this pull request
Polling error with conductor-python 1.0.33 #107
Closed
@gardusig gardusig linked an issue Jul 24, 2022 that may be closed by this pull request
Create integration tests for general use case #38
Closed
@gardusig gardusig linked an issue Jul 25, 2022 that may be closed by this pull request
Invalid value for name #94
Closed
@gardusig gardusig merged commit 88b7b8a into main Jul 25, 2022
@gardusig gardusig deleted the feature/worker-as-python-callable branch July 25, 2022 02:10
@gardusig gardusig linked an issue Jul 25, 2022 that may be closed by this pull request
Add validation step for GitHub Action after publish release event #100
Closed
This was unlinked from issues Jul 25, 2022
Add support for Worker with generic output #104
Closed
Add support for Worker with generic input #103
Closed
@hebrd
Copy link
Contributor

hebrd commented Jul 25, 2022

I can not install the latest version 1.0.34 by pip so far. when will the new release exist in the pypi repo?

@gardusig
Copy link
Contributor Author

gardusig commented Jul 25, 2022 •
edited
Loading

Hey @BrandonDotLin, can you try running this command?

python3 -m pip install conductor-python==v1.0.34

@hebrd
Copy link
Contributor

hebrd commented Jul 29, 2022

Hey @BrandonDotLin, can you try running this command?

python3 -m pip install conductor-python==v1.0.34

ERROR: No matching distribution found for conductor-python==v1.0.34

It seems there has been a delay in publication to pypi repo. I can install via below command now:

pip install conductor-python==1.0.34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v1r3n v1r3n v1r3n approved these changes

Assignees

@gardusig gardusig

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@gardusig @hebrd @v1r3n