You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
While not necessarily breaking anything, Conduit should make sure its proto files abide by the official Protocol Buffers style guide.
I have yet to cross-check every single one of them, but at a first glance, it seems like we're mostly ignoring case conventions.
Namely snake_case for files (eg push-notifications.proto) and, sometimes, CamelCase for services and rpcs (eg Database's rpc findOne).
Expected behavior
Conduit's proto files should respect the official style guide, making sure they follow case conventions etc.
The text was updated successfully, but these errors were encountered:
Its not as simple as it seems. First of all changing the naming in the proto files will cause a huge collision
between Typescript and gRPC naming conventions.
Also , the gRPC's servers will crash because of rpc messages. ( Cause the naming will be changed).
gRPC Server Implementation
So, in order to solve this problem the gRPC server implementation should be changed. ts-proto tool must be used in order to auto-generate the proper service/message interfaces.
Using this tool requires to create a Server Class for each module which implements the auto-generated interfaces
But there is a major problem in this solution: It is difficult to implement a server class for the Router because the proto files are auto-generated.
Yeah the solution seems to require quite a bit of refactoring. I'm trying to understand if we tangled ourselves into this mess or it was bound to get messy either way. We'll need to have a design meeting on discord for this to figure out a proper approach to untangle this thing.
Describe the bug
While not necessarily breaking anything, Conduit should make sure its proto files abide by the official Protocol Buffers style guide.
I have yet to cross-check every single one of them, but at a first glance, it seems like we're mostly ignoring case conventions.
Namely snake_case for files (eg
push-notifications.proto
) and, sometimes, CamelCase for services and rpcs (eg Database'srpc findOne
).Expected behavior
Conduit's proto files should respect the official style guide, making sure they follow case conventions etc.
The text was updated successfully, but these errors were encountered: