indexer: disable warnings and skip processed function bodies

Adapt clang rC370337: removal of createIndexingAction and WrappingIndexAction
condy0919 · Oct 25, 2019 · 4534393 · 4534393
1 parent 5422afe
commit 4534393
Show file tree

Hide file tree

Showing 3 changed files with 49 additions and 11 deletions.
diff --git a/src/clang_tu.cc b/src/clang_tu.cc
@@ -84,6 +84,8 @@ buildCompilerInvocation(const std::string &main, std::vector<const char *> args,
   if (ci) {
     ci->getDiagnosticOpts().IgnoreWarnings = true;
     ci->getFrontendOpts().DisableFree = false;
+    // Enable IndexFrontendAction::shouldSkipFunctionBody.
+    ci->getFrontendOpts().SkipFunctionBodies = true;
     ci->getLangOpts()->SpellChecking = false;
     auto &isec = ci->getFrontendOpts().Inputs;
     if (isec.size())

diff --git a/src/indexer.cc b/src/indexer.cc
@@ -11,6 +11,7 @@
 
 #include <clang/AST/AST.h>
 #include <clang/Frontend/FrontendAction.h>
+#include <clang/Frontend/MultiplexConsumer.h>
 #include <clang/Index/IndexDataConsumer.h>
 #include <clang/Index/IndexingAction.h>
 #include <clang/Index/USRGeneration.h>
@@ -1150,16 +1151,43 @@ class IndexPPCallbacks : public PPCallbacks {
 };
 
 class IndexFrontendAction : public ASTFrontendAction {
+  std::shared_ptr<IndexDataConsumer> dataConsumer;
+  const index::IndexingOptions &indexOpts;
   IndexParam &param;
 
 public:
-  IndexFrontendAction(IndexParam &param) : param(param) {}
-  std::unique_ptr<ASTConsumer> CreateASTConsumer(CompilerInstance &CI,
-                                                 StringRef InFile) override {
-    Preprocessor &PP = CI.getPreprocessor();
-    PP.addPPCallbacks(
-        std::make_unique<IndexPPCallbacks>(PP.getSourceManager(), param));
-    return std::make_unique<ASTConsumer>();
+  IndexFrontendAction(std::shared_ptr<IndexDataConsumer> dataConsumer,
+                      const index::IndexingOptions &indexOpts,
+                      IndexParam &param)
+      : dataConsumer(std::move(dataConsumer)), indexOpts(indexOpts),
+        param(param) {}
+  std::unique_ptr<ASTConsumer> CreateASTConsumer(CompilerInstance &ci,
+                                                 StringRef inFile) override {
+    class SkipProcessed : public ASTConsumer {
+      IndexParam &param;
+      const ASTContext *ctx = nullptr;
+
+    public:
+      SkipProcessed(IndexParam &param) : param(param) {}
+      void Initialize(ASTContext &ctx) override { this->ctx = &ctx; }
+      bool shouldSkipFunctionBody(Decl *d) override {
+        const SourceManager &sm = ctx->getSourceManager();
+        FileID fid = sm.getFileID(sm.getExpansionLoc(d->getLocation()));
+        return !(g_config->index.multiVersion && param.useMultiVersion(fid)) &&
+               !param.consumeFile(fid);
+      }
+    };
+
+    std::shared_ptr<Preprocessor> pp = ci.getPreprocessorPtr();
+    pp->addPPCallbacks(
+        std::make_unique<IndexPPCallbacks>(pp->getSourceManager(), param));
+    std::vector<std::unique_ptr<ASTConsumer>> consumers;
+    consumers.push_back(std::make_unique<SkipProcessed>(param));
+#if LLVM_VERSION_MAJOR >= 10 // rC370337
+    consumers.push_back(index::createIndexingASTConsumer(
+        dataConsumer, indexOpts, std::move(pp)));
+#endif
+    return std::make_unique<MultiplexConsumer>(std::move(consumers));
   }
 };
 } // namespace
@@ -1244,6 +1272,7 @@ index(SemaManager *manager, WorkingFiles *wfiles, VFS *vfs,
   auto clang = std::make_unique<CompilerInstance>(pch);
   clang->setInvocation(std::move(ci));
   clang->createDiagnostics(&dc, false);
+  clang->getDiagnostics().setIgnoreAllWarnings(true);
   clang->setTarget(TargetInfo::CreateTargetInfo(
       clang->getDiagnostics(), clang->getInvocation().TargetOpts));
   if (!clang->hasTarget())
@@ -1259,7 +1288,6 @@ index(SemaManager *manager, WorkingFiles *wfiles, VFS *vfs,
                                             clang->getFileManager(), true));
 
   IndexParam param(*vfs, no_linkage);
-  auto dataConsumer = std::make_shared<IndexDataConsumer>(param);
 
   index::IndexingOptions indexOpts;
   indexOpts.SystemSymbolFilter =
@@ -1275,8 +1303,16 @@ index(SemaManager *manager, WorkingFiles *wfiles, VFS *vfs,
 #endif
   }
 
-  std::unique_ptr<FrontendAction> action = createIndexingAction(
-      dataConsumer, indexOpts, std::make_unique<IndexFrontendAction>(param));
+#if LLVM_VERSION_MAJOR >= 10 // rC370337
+  auto action = std::make_unique<IndexFrontendAction>(
+      std::make_shared<IndexDataConsumer>(param), indexOpts, param);
+#else
+  auto dataConsumer = std::make_shared<IndexDataConsumer>(param);
+  auto action = createIndexingAction(
+      dataConsumer, indexOpts,
+      std::make_unique<IndexFrontendAction>(dataConsumer, indexOpts, param));
+#endif
+
   std::string reason;
   {
     llvm::CrashRecoveryContext crc;

diff --git a/src/sema_manager.cc b/src/sema_manager.cc
@@ -466,7 +466,6 @@ void *completionMain(void *manager_) {
     fOpts.CodeCompletionAt.FileName = task->path;
     fOpts.CodeCompletionAt.Line = task->position.line + 1;
     fOpts.CodeCompletionAt.Column = task->position.character + 1;
-    fOpts.SkipFunctionBodies = true;
     ci->getLangOpts()->CommentOpts.ParseAllComments = true;
 
     DiagnosticConsumer dc;
@@ -572,6 +571,7 @@ void *diagnosticMain(void *manager_) {
     if (lookupExtension(session->file.filename).second)
       ci->getDiagnosticOpts().Warnings.push_back("no-unused-function");
     ci->getDiagnosticOpts().IgnoreWarnings = false;
+    ci->getFrontendOpts().SkipFunctionBodies = false;
     ci->getLangOpts()->SpellChecking = g_config->diagnostics.spellChecking;
     StoreDiags dc(task.path);
     std::string content = manager->wfiles->getContent(task.path);