Fix gtag cookie settings #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cone-development-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@iamgergo Please open your console and see before + after on https://cone-development-site.netlify.app/ |
szepeviktor
commented
Aug 28, 2023
| @@ -17,5 +17,8 @@ if (getCookie('cone-cookie-law-analytics') === 'accepted') { | |||
| window.dataLayer = window.dataLayer || []; | |||
|
|
|||
| gtag('js', new Date()); | |||
| gtag('config', coneGtagId); | |||
| gtag('config', coneGtagId, { | |||
| 'cookie_domain': window.location.hostname, | |||
There was a problem hiding this comment.
This may be document.location
There was a problem hiding this comment.
Others mention that is should not be added in config but in a separate gtag('set', { ... }); before config.
|
Thanks I will test it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox and maybe other browsers warn about non-samesite cookies on the browser console.
https://developers.google.com/analytics/devguides/collection/ga4/reference/config#cookie_flags