Skip to content
This repository has been archived by the owner on Sep 15, 2018. It is now read-only.

fix tests to not need environment variables so that circle can run successfully on forks #6

Closed
meara opened this issue Jun 17, 2016 · 3 comments
Closed

fix tests to not need environment variables so that circle can run successfully on forks #6

meara opened this issue Jun 17, 2016 · 3 comments

Comments

@meara
Copy link

meara commented Jun 17, 2016

For PRs from forks, circle builds will fail with KeyError: key not found: "TWITTER_CONSUMER_KEY".
Example build: https://circleci.com/gh/minifast/conference-opportunities/131

Apparently environment variables are not available on forks for security reasons:
https://circleci.com/docs/fork-pr-builds/

The test suite needs to not depend on environment variables so that circle builds will be possible for PRs from forks.
@sarahmei sarahmei mentioned this issue Jun 17, 2016
Merged
@ohrite
Copy link
Member

ohrite commented Aug 2, 2016

Hi @meara!

This is an awesome observation, and @cczona told me all about what happened here. Is this still happening for you?

@ohrite
Copy link
Member

ohrite commented Aug 4, 2016

@meara After #10 by @sarahmei, I think this might be resolved. Sound good? 😄

@ohrite
Copy link
Member

ohrite commented Aug 5, 2016

Closing for now!

@ohrite ohrite closed this as completed Aug 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ohrite @meara