-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving base Confetti Framework components #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval, but maybe we should move github.com/confetti-framework/framework/contract/inter to github.com/confetti-framework/framework/inter (see other issue)
Okay I will try move it later today! |
Just moved |
Very nice! Is there anything else that needs to be done? In that case, I'll test it today. I will also refactor https://github.com/confetti-framework/commands to the framework repo. That's a stripped-down version of the confetti framework. |
Νο everything is fine from my side. |
Thanks! I will test and merge it today and tomorrow. |
It all works fine 🥳 . I've also updated repo commands. But baker doesn't work yet 😢 :
I don't see how quickly I can solve the problem. Do you have an idea? I've been busy updating repo baker with the upstream today. After resolving conflicts, tests fail in that repo, so I need to troubleshoot those further (see confetti-framework/baker#3) |
I think it works now. It must have been my environment. I'll merge it and make a release for it. |
https://github.com/confetti-framework/confetti/releases/tag/v0.29.0 🥳 Thanks for all your work! |
This PR removes the following import in favor of
github.com/confetti-framework/framework
github.com/confetti-framework/contract
github.com/confetti-framework/foundation
github.com/confetti-framework/support
github.com/confetti-framework/validation