Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming of BlazorTemplater class to different name #4

Closed
4 tasks
conficient opened this issue Apr 13, 2021 · 1 comment
Closed
4 tasks

Consider renaming of BlazorTemplater class to different name #4

conficient opened this issue Apr 13, 2021 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@conficient
Copy link
Owner

conficient commented Apr 13, 2021

Testing the library in an application I found it awkward having the renderer class name the same as the namespace. I wasn't able to add a using for the namespace and then use the BlazorTemplater class. I think it's recommended against in C# guidelines somewhere, so will rename.

Possible alternatives:

  • Templater
  • Renderer
  • RenderHost

Need to:

  • Make breaking change, as 1.1
  • Rename references in the code/tests
  • Amend documentation
  • Amend renderer variable names to templater
@conficient conficient changed the title Consider renaming of BlazorRenderer class to different name Consider renaming of BlazorTemplater class to different name Apr 13, 2021
@conficient conficient added the bug Something isn't working label Apr 13, 2021
@conficient conficient added this to the v1.1 milestone Apr 13, 2021
@conficient
Copy link
Owner Author

Should also change name of vars from renderer to templater in sample code and tests.

@conficient conficient self-assigned this Apr 13, 2021
conficient added a commit that referenced this issue Apr 13, 2021
Rename `BlazorTemplater` class to `Templater`. Fixes #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant