Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to tenacity 8.4.1 #847

Open
FrancoisMasson1990 opened this issue Jun 24, 2024 · 3 comments
Open

Update to tenacity 8.4.1 #847

FrancoisMasson1990 opened this issue Jun 24, 2024 · 3 comments

Comments

@FrancoisMasson1990
Copy link

❗BEFORE YOU BEGIN❗
Are you on discord? 🤗 We'd love to have you asking questions on discord instead: https://discord.com/invite/a3K9c8GRGt

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

The following bug has been fixed with tenacity 8.4.1

langchain-ai/langchain#22972

@penguine-ip
Copy link
Contributor

@FrancoisMasson1990 do you mean update the pip dependencies required by deepeval (specifically tenacity) to 8.4.1 because of the same bug you're encourting on the langchain thread?

@Trevoke
Copy link

Trevoke commented Jul 10, 2024

I would like a tenacity update because it's currently impossible to have the most recent weave (from wandb) and deepeval in the same repo:

ERROR: Unable to find a resolution for tenacity
because of the following conflicts:
  tenacity!=8.4.0,>=8.3.0 (from weave@0.50.7)
  tenacity<9.0.0,>=8.2.3 (from instructor@1.3.0)
  tenacity~=8.2.3 (from deepeval@0.21.65)

@FrancoisMasson1990
Copy link
Author

Yes, basically

@FrancoisMasson1990 do you mean update the pip dependencies required by deepeval (specifically tenacity) to 8.4.1 because of the same bug you're encourting on the langchain thread?

Yes exactly. There is mismatch version conflict that can be solved by relaxing and updating the tenacity version.
Can you do the same with protobuf and upgrade to 5.x version ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants