Skip to content
This repository has been archived by the owner on Jul 2, 2023. It is now read-only.

Rename Occlum attester to SGX attester and add Gramine support to it #212

Closed
wants to merge 3 commits into from

Conversation

mythi
Copy link

@mythi mythi commented Jun 3, 2023

WIP: I'm planning to change the existing occlum-attester to sgx-dcap-attester.

TODO:

  • rename feature names
  • rename structs/modules
  • rebase this PR

Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
SGX DCAP Attester checks that the evidence passed in is base64
encoded SHA384 and fails if the base64 decoded input does not
match the expected length.

Therefore, "test".into() won't work and errors. Fix by using
the same hasher as the KBS protocol.

Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
@mythi mythi changed the title WIP: Add Gramine support to SGX Attester Rename Occlum attester to SGX attester and add Gramine support to it Jun 13, 2023
@mythi mythi marked this pull request as ready for review June 13, 2023 10:25
@mythi
Copy link
Author

mythi commented Jun 13, 2023

/cc @Xynnn007

I've tested both Gramine and Occlum paths manually. Occlum tester is also fixed and can be added back to CI.

Copy link
Member

@Xynnn007 Xynnn007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I like the reorganization.

attester/src/sgx_dcap/mod.rs Show resolved Hide resolved
@mythi
Copy link
Author

mythi commented Jun 22, 2023

moved to image-rs

@mythi mythi closed this Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants