podvm-mkosi: remove cloud-init #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katexochen
force-pushed
the
feat/mkosi-no-cloudinit
branch
2 times, most recently
from
5346d85
to
dd8acc2
Compare
mkulke
reviewed
Nov 13, 2023
We have our own mechanism to fetch metadata from IMDS. This is far more flexible than using cloud init, especially regarding the upcoming switch to an read-only root FS. Thus removing cloud init support for mkosi images with this commit. Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
Some additional debug utils. Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
katexochen
force-pushed
the
feat/mkosi-no-cloudinit
branch
from
dd8acc2
to
608879c
Compare
mkulke
approved these changes
Nov 13, 2023
Comment on lines
+18
to
+20
| iputils | ||
| curl | ||
| wget |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #1524, which should be reviewed and merged first.
Fixes #1467 (for x86, we should check with the IBM folks if they want to remove cloud init for s390x as well)
This requires
DISABLE_CLOUD_CONFIG=truein yourinstall/overlay/${CSP}/kustomization.yaml