Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure: Misc e2e fixes #1568

Merged
merged 1 commit into from
Nov 29, 2023
Merged

azure: Misc e2e fixes #1568

merged 1 commit into from
Nov 29, 2023

Conversation

mkulke
Copy link
Contributor

@mkulke mkulke commented Nov 10, 2023

  • Do not overwrite image_id in e2e test when specified, at the moment it will be ignored
  • Add cluster subnet id to provisioner file to we can decouple running tests from cluster installation

@mkulke
azure: Misc e2e fixes
224bf29 
- Do not overwrite image_id in e2e test when specified, at the moment
  it will be ignored
- Add cluster subnet id to provisioner file to we can decouple running
  tests from cluster installation

Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
@mkulke mkulke added provider/azure Issues related to Azure CAA provider e2e-test labels Nov 10, 2023
@surajssd
Copy link
Member

Add cluster subnet id to provisioner file to we can decouple running tests from cluster installation

What does this mean?

@mkulke
Copy link
Contributor Author

mkulke commented Nov 16, 2023

Add cluster subnet id to provisioner file to we can decouple running tests from cluster installation

What does this mean?

Currently, a CAA deployment will only work if it's coupled with an AKS cluster creation in --action=provision. The CreateCluster fn has a side effect that sets SubnetId to the provisioner process, so it's available for CAA deployment but after the process ends it's lost. This step simply performs the same thing, but adds the subnet to the test provision file, so we are able to split infra provisioning and CAA deployment at a later point.

@kartikjoshi21 kartikjoshi21 merged commit c84f84d into confidential-containers:main Nov 29, 2023
29 checks passed
@mkulke mkulke deleted the mkulke/azure-e2e-fixes branch November 29, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surajssd surajssd surajssd approved these changes

@kartikjoshi21 kartikjoshi21 kartikjoshi21 approved these changes

@iaguis iaguis Awaiting requested review from iaguis

Assignees
No one assigned
Labels
e2e-test provider/azure Issues related to Azure CAA provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkulke @surajssd @kartikjoshi21