docs: Development guide - small fixes #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katexochen
reviewed
Nov 14, 2023
make fails without yq installed. Fixes confidential-containers#1577 Signed-off-by: Beraldo Leal <bleal@redhat.com>
Those are kata-containers specifics, and ideally should be part of kata-containers documentation to avoid getting out of date bits. Also, iiuc, in order to build the runtime, there is no need to have protoc, since they are pre-compiled and versioned. Signed-off-by: Beraldo Leal <bleal@redhat.com>
As suggested during PR review. Signed-off-by: Beraldo Leal <bleal@redhat.com>
beraldoleal
force-pushed
the
development-fixes
branch
from
c020125
to
18d78c0
Compare
katexochen
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.