azure: aws: set defaults from environment to instanceTypes #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make sure it's also when caa is used as library. Signed-off-by: Snir Sheriber <ssheribe@redhat.com>
snir911
force-pushed
the
default_instance_types
branch
from
fafe862
to
3583dbe
Compare
bpradipt
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
/lgtm
I think it's better to update the default here as well for consistency - https://github.com/confidential-containers/cloud-api-adaptor/blob/main/install/overlays/azure/kustomization.yaml#L23
to Standard_DC2as_v5 based on azure/README.md and also set from env to make sure it's also when caa is used as library Signed-off-by: Snir Sheriber <ssheribe@redhat.com>
snir911
force-pushed
the
default_instance_types
branch
from
3583dbe
to
19a0c6e
Compare
snir911
changed the title
surajssd
approved these changes
Nov 16, 2023
mkulke
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and setting default CVM type for Azure
setting using env fixes peerpod-ctrl error:
The following supplied instance types do not exist: []