Remove duplicate config scripts from packer configs and misc cleanups #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snir911
reviewed
Nov 19, 2023
|
also, about centos? what about support for qcow based centos? it seems it's used: |
I'll create a separate issue to remove centos from qcow2. |
Use the configuration scripts from the podvm dir and avoid duplicating the files. Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
We are no longer building/testing centos based images using packer. Remove it to reduce maintenance overhead Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Use the configuration scripts from the podvm dir and avoid duplicating the files. Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
We are no longer building/testing centos based images using packer. Remove it to reduce maintenance overhead Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
This ensures a single place to initialise packer for both docker and regular builds. Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
bpradipt
force-pushed
the
remove-dups
branch
from
f0e5d06
to
639422b
Compare
mkulke
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following: