workflows: fix checkout of the code on podvm #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As currently implemented on builder/binaries/podvm workflows, the actions/checkout@v3 will checkout the code based on GITHUB_SHA. When used with the pull_request_target event (which is the case of the tests for libvirt on pull request), GITHUB_SHA is the SHA of the base branch but we are interested on the SHA of the head on the pull request branch (i.e. github.event.pull_request.head.sha). Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
stevenhorsman
approved these changes
Nov 21, 2023
snir911
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As currently implemented on builder/binaries/podvm workflows, the actions/checkout@v3 will checkout the code based on GITHUB_SHA. When used with the pull_request_target event (which is the case of the tests for libvirt on pull request), GITHUB_SHA is the SHA of the base branch but we are interested on the SHA of the head on the pull request branch (i.e. github.event.pull_request.head.sha).