Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/e22: libvirt: Add delete pod test #1608

Merged
merged 1 commit into from
Dec 11, 2023
Merged

test/e22: libvirt: Add delete pod test #1608

merged 1 commit into from
Dec 11, 2023

Conversation

stevenhorsman
Copy link
Member

Add delete pod test to libvirt e2e as part of #1604 libvirt gap closes

@wainersm wainersm added the test_e2e_libvirt Run Libvirt e2e tests label Dec 4, 2023
wainersm
wainersm approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stevenhorsman !

@wainersm
Copy link
Member

wainersm commented Dec 6, 2023

@ldoktor mind to review this one too?

@ldoktor
Copy link
Contributor

ldoktor commented Dec 7, 2023

@ldoktor mind to review this one too?

Well, as a go beginner and complete stranger to the cloud-api-adaptor repo the only things I can say the doTestDeleteSimplePod function is defined in common_suite_test.go so it looks good. I even found in README how to execute the suite but at this point don't really have time to experiment on executing this test (maybe tomorrow or next week, no promises, though, but I do want to get this working on my machine eventually).

The CI failed to create the pod vm image but it looks like centos setup issue unrelated to this PR but due to that the e2e tests/libvirt was skipped.

@stevenhorsman
test/e22: libvirt: Add delete pod test
8e4f393 
Add delete pod test to libvirt e2e as part of confidential-containers#1604 libvirt gap closes

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
@wainersm
Copy link
Member

wainersm commented Dec 8, 2023

@ldoktor mind to review this one too?

Well, as a go beginner and complete stranger to the cloud-api-adaptor repo the only things I can say the doTestDeleteSimplePod function is defined in common_suite_test.go so it looks good. I even found in README how to execute the suite but at this point don't really have time to experiment on executing this test (maybe tomorrow or next week, no promises, though, but I do want to get this working on my machine eventually).

The CI failed to create the pod vm image but it looks like centos setup issue unrelated to this PR but due to that the e2e tests/libvirt was skipped.

The workflow to run the libvirt e2e tests was broken when you made that comment. With recent fixes applied it is now passing.

@snir911 snir911 merged commit 1fc52f0 into confidential-containers:main Dec 11, 2023
27 checks passed
@stevenhorsman stevenhorsman deleted the libvirt-delete-test branch December 11, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wainersm wainersm wainersm approved these changes

@snir911 snir911 snir911 approved these changes

Assignees
No one assigned
Labels
test_e2e_libvirt Run Libvirt e2e tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stevenhorsman @wainersm @ldoktor @snir911