Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: workflows: install docker in e2e_libvirt #1618

Merged

Conversation

wainersm
Copy link
Member

@wainersm wainersm commented Dec 6, 2023

Docker is required to pull and extract the podvm qcow2.

I hope it fixes the problem on #1617

@wainersm wainersm added the test_e2e_libvirt Run Libvirt e2e tests label Dec 6, 2023
@wainersm
Copy link
Member Author

wainersm commented Dec 6, 2023

Of course, Wainer, libvirt e2e will fail because it depends on #1617

Docker is required to pull and extract the podvm qcow2.

Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
@wainersm wainersm changed the title workflows: install docker in e2e_libvirt WIP: workflows: install docker in e2e_libvirt Dec 6, 2023
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@wainersm
Copy link
Member Author

wainersm commented Dec 6, 2023

still figuring out how to properly test it

Copy link
Member

@liudalibj liudalibj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liudalibj liudalibj merged commit a466f5f into confidential-containers:main Dec 7, 2023
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test_e2e_libvirt Run Libvirt e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants