Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podvm: remove CentOS support #1619

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

wainersm
Copy link
Member

@wainersm wainersm commented Dec 6, 2023

The podvm build for CentOS has been broken for a while now (see #1558) and even on the last release (0.8.0) we didn't publish an image. After some discussions in #1564 and in our community's meeting today there is a consensus that CentOS support can be dropped.

Important to say that we will continue building an RPM-based distro (Fedora) but with the mkosi tool instead of packer.

Somehow-fixes #1558
Signed-off-by: Wainer dos Santos Moschetta wainersm@redhat.com

The podvm build for CentOS has been broken for a while now (see confidential-containers#1558)
and even on the last release (0.8.0) we didn't publish an image. After
some discussions in confidential-containers#1564
and in our community's meeting today there is a consensus that CentOS
support can be dropped.

Important to say that we will continue building an RPM-based distro
(Fedora) but with the mkosi tool instead of packer.

Somehow-fixes confidential-containers#1558
Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
@wainersm wainersm added the test_e2e_libvirt Run Libvirt e2e tests label Dec 6, 2023
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@wainersm
Copy link
Member Author

wainersm commented Dec 6, 2023

Tested this PR in https://github.com/wainersm/cc-cloud-api-adaptor/actions/runs/7120480521 . It was able to build the builder, binaries and podvm images only of Ubuntu.

Copy link
Member

@liudalibj liudalibj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @wainersm

@wainersm wainersm added test_e2e_libvirt Run Libvirt e2e tests and removed test_e2e_libvirt Run Libvirt e2e tests labels Dec 12, 2023
@wainersm wainersm merged commit 81ac36d into confidential-containers:main Dec 13, 2023
28 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test_e2e_libvirt Run Libvirt e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

centos ssh timeout on podvm image build
4 participants