-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
versions: Bump golang #1620
versions: Bump golang #1620
Conversation
stevenhorsman
commented
Dec 7, 2023
- Bump to go 1.20.12 to resolve https://pkg.go.dev/vuln/GO-2023-2382
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@bpradipt - sorry Pradipta, I think you left a comment, rather than approval, so it still needs a second green tick. Thanks! |
@stevenhorsman have you used hack/update-go-container.sh to bump the version? And next you will send a PR to update Dockerfile? |
Yes - that's where all the checksums automatically were gen'd by
Sorry, which Dockerfile? Did I miss something? |
- Bump to go 1.20.12 to resolve https://pkg.go.dev/vuln/GO-2023-2382 Signed-off-by: stevenhorsman <steven@uk.ibm.com>
39a3a63
to
18a4e79
Compare
Yeah sorry about it. |
Adding hold label until I understand from Wainer what I've missed |
I was talking about https://github.com/confidential-containers/cloud-api-adaptor/blob/main/Dockerfile#L2 . |
Okay, so something that has to be done as follow up and the image won't be build yet. Understood and thanks for the reminder (that it looks like we've forgotten the last few times). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stevenhorsman !
Now the base image has been built and pushed to quay.io - I've created #1621 to use it |