Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versions: Bump golang #1620

Merged

Conversation

stevenhorsman
Copy link
Member

Copy link
Contributor

@tumberino tumberino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@stevenhorsman
Copy link
Member Author

@bpradipt - sorry Pradipta, I think you left a comment, rather than approval, so it still needs a second green tick. Thanks!

@wainersm wainersm added the test_e2e_libvirt Run Libvirt e2e tests label Dec 7, 2023
@wainersm
Copy link
Member

wainersm commented Dec 7, 2023

@stevenhorsman have you used hack/update-go-container.sh to bump the version?

And next you will send a PR to update Dockerfile?

@stevenhorsman
Copy link
Member Author

stevenhorsman commented Dec 7, 2023

@stevenhorsman have you used hack/update-go-container.sh to bump the version?

Yes - that's where all the checksums automatically were gen'd by

And next you will send a PR to update Dockerfile?

Sorry, which Dockerfile? Did I miss something?
I just spotted that I missed the power pre-req scrip that isn't using versions.yaml, but I guess that's not what you are referring too.

- Bump to go 1.20.12 to resolve
https://pkg.go.dev/vuln/GO-2023-2382

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
@bpradipt
Copy link
Member

bpradipt commented Dec 7, 2023

@bpradipt - sorry Pradipta, I think you left a comment, rather than approval, so it still needs a second green tick. Thanks!

Yeah sorry about it.

@stevenhorsman
Copy link
Member Author

Adding hold label until I understand from Wainer what I've missed

@wainersm
Copy link
Member

wainersm commented Dec 7, 2023

Adding hold label until I understand from Wainer what I've missed

I was talking about https://github.com/confidential-containers/cloud-api-adaptor/blob/main/Dockerfile#L2 .

@stevenhorsman
Copy link
Member Author

I was talking about https://github.com/confidential-containers/cloud-api-adaptor/blob/main/Dockerfile#L2 .

Okay, so something that has to be done as follow up and the image won't be build yet. Understood and thanks for the reminder (that it looks like we've forgotten the last few times).

Copy link
Member

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stevenhorsman !

@stevenhorsman stevenhorsman merged commit de4c21e into confidential-containers:main Dec 7, 2023
39 checks passed
@stevenhorsman stevenhorsman deleted the go-1.20.12 branch December 7, 2023 14:22
@stevenhorsman
Copy link
Member Author

I was talking about https://github.com/confidential-containers/cloud-api-adaptor/blob/main/Dockerfile#L2 .

Okay, so something that has to be done as follow up and the image won't be build yet. Understood and thanks for the reminder (that it looks like we've forgotten the last few times).

Now the base image has been built and pushed to quay.io - I've created #1621 to use it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test_e2e_libvirt Run Libvirt e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants