e2e-test: grep for container id in nydus test #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkulke
requested review from
surajssd,
bpradipt,
kartikjoshi21 and
stevenhorsman
|
@bpradipt Is it ok to assume |
stevenhorsman
approved these changes
Dec 12, 2023
surajssd
reviewed
Dec 13, 2023
mkulke
force-pushed
the
mkulke/grep-for-cid-in-nydus-test
branch
from
939a12d
to
288c5e7
Compare
when testing in parallel, just listening for the last log won't work, we'll get matches for unrelated peerpod log lines. Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
mkulke
force-pushed
the
mkulke/grep-for-cid-in-nydus-test
branch
from
288c5e7
to
5d914fd
Compare
surajssd
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when testing in parallel, just listening for the last log won't work, we'll get matches for unrelated peerpod log lines.