Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: make existing provider managers can be reused #1629

Merged
merged 1 commit into from
Dec 21, 2023
Merged

provider: make existing provider managers can be reused #1629

merged 1 commit into from
Dec 21, 2023

Conversation

liudalibj
Copy link
Member

@liudalibj liudalibj commented Dec 20, 2023 •
edited

  • Add new GetConfig function

Fixes #1628

@liudalibj
Copy link
Member Author

https://libvirt.org/ can be accessed from my dev machine, didn't find out what's make https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/7270996164/job/19810981198?pr=1629 FAIL.

@liudalibj liudalibj changed the title provider: make libvirt and ibmcloud manager can be reused provider: make exsiting provider managers can be reused Dec 20, 2023
@liudalibj liudalibj changed the title provider: make exsiting provider managers can be reused provider: make existing provider managers can be reused Dec 20, 2023
@liudalibj
Copy link
Member Author

https://libvirt.org/ can be accessed from my dev machine, didn't find out what's make https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/7270996164/job/19810981198?pr=1629 FAIL.

Re-run the failed task, it's PASS now.

mkulke
mkulke reviewed Dec 20, 2023
View reviewed changes
libvirt/install_operator.sh Outdated Show resolved Hide resolved
@liudalibj
provider: make existing provider managers can be reused
7967263 
- Add new GetConfig function

Fixes confidential-containers#1628

Signed-off-by: Da Li Liu <liudali@cn.ibm.com>
huoqifeng
huoqifeng approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@huoqifeng huoqifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

stevenhorsman
stevenhorsman approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@huoqifeng huoqifeng merged commit 2fe49c7 into confidential-containers:main Dec 21, 2023
16 checks passed
@liudalibj liudalibj mentioned this pull request Dec 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkulke mkulke mkulke approved these changes

@huoqifeng huoqifeng huoqifeng approved these changes

@stevenhorsman stevenhorsman stevenhorsman approved these changes

@yoheiueda yoheiueda Awaiting requested review from yoheiueda

@tumberino tumberino Awaiting requested review from tumberino

@bpradipt bpradipt Awaiting requested review from bpradipt

@genjuro214 genjuro214 Awaiting requested review from genjuro214

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make existing provider managers can be reused
4 participants
@liudalibj @mkulke @huoqifeng @stevenhorsman