azure: fix image reference string #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The community gallery is supposed to be stored as var not as a secret, reference is usage in the nightly image build. Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
iaguis
approved these changes
Dec 20, 2023
surajssd
approved these changes
Dec 21, 2023
|
Are these vars exposed though? If not the next run will fail. |
I think so, as the nightly image builds use them atm, and they seem to work there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The community gallery and image definition are supposed to be stored as vars not as secret, reference is usage in the nightly image build.
cloud-api-adaptor/.github/workflows/azure-podvm-image-build.yml
Lines 29 to 31 in afe662c