e2e: enable more than one pod in one test case #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyuany
force-pushed
the
e2e-enable-extra-pods
branch
3 times, most recently
from
abcf6a1
to
3434d4f
Compare
|
The case is tested against self managed cluster on ibmcloud. Test log as below. |
liudalibj
reviewed
Jan 2, 2024
test/e2e/common_suite_test.go
Outdated
| @@ -445,3 +445,38 @@ func doTestPodVMwithAnnotationsLargerCPU(t *testing.T, assert CloudAssert) { | |||
| } | |||
| newTestCase(t, "PodVMwithAnnotationsLargerCPU", assert, "Failed to Create PodVM with Annotations Larger CPU").withPod(pod).withInstanceTypes(testInstanceTypes).withCustomPodState(v1.PodPending).run() | |||
| } | |||
|
|
|||
| func doTestExtraPods(t *testing.T, assert CloudAssert) { | |||
There was a problem hiding this comment.
All the other test cases are have one test content related name, can we change this function name to
doTestServiceAndExtraPod
liudalibj
reviewed
Jan 2, 2024
test/e2e/ibmcloud_test.go
Outdated
| @@ -502,6 +502,13 @@ func TestIBMCreateNginxDeployment(t *testing.T) { | |||
| doTestNginxDeployment(t, assert) | |||
| } | |||
|
|
|||
| func TestExtraPods(t *testing.T) { | |||
There was a problem hiding this comment.
All the other test cases are have one test content related name, can we change this function name to
TestServiceAndExtraPod
There was a problem hiding this comment.
And this test is good for other providers, so maybe we add this test case in other provider test file too, at last include it in the libvirt_test.go, TestLibvirtServiceAndExtraPod ?
There was a problem hiding this comment.
How about rename to TestPodToServiceCommunication?
wyuany
force-pushed
the
e2e-enable-extra-pods
branch
from
667242a
to
c37d3b7
Compare
huoqifeng
reviewed
Jan 2, 2024
test/e2e/ibmcloud_test.go
Outdated
| @@ -502,6 +502,13 @@ func TestIBMCreateNginxDeployment(t *testing.T) { | |||
| doTestNginxDeployment(t, assert) | |||
| } | |||
|
|
|||
| func TestExtraPods(t *testing.T) { | |||
There was a problem hiding this comment.
How about rename to TestPodToServiceCommunication?
wyuany
force-pushed
the
e2e-enable-extra-pods
branch
2 times, most recently
from
f31994e
to
e74e0e6
Compare
Enable test framework to support more than one pod in one test case Fixes: confidential-containers#16 Signed-off-by: Yuan Yuan Wang <wyuany@cn.ibm.com>
wyuany
force-pushed
the
e2e-enable-extra-pods
branch
from
e74e0e6
to
57b8fd7
Compare
liudalibj
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable test framework to support more than one pod in one test case
Fixes: #16