Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peerpod-ctrl: deprecate cloudmgr #1648

Merged
merged 1 commit into from
Jan 4, 2024
Merged

peerpod-ctrl: deprecate cloudmgr #1648

merged 1 commit into from
Jan 4, 2024

Conversation

genjuro214
Copy link
Contributor

cloudmgr has been removed in latest CAA code, referring following commits:
5a77d63
4ba026a

So we need update peerpod-ctrl code to deprecate cloudmgr.

Also including 5 providers under controllers package according to the default value of BUILTIN_CLOUD_PROVIDERS in Makefile

cloudmgr has been removed in latest CAA code

Signed-off-by: Lei Li <genjuro214@gmail.com>
Signed-off-by: Lei Li <cdlleili@cn.ibm.com>
Copy link
Member

@liudalibj liudalibj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks @genjuro214

Copy link
Contributor

@huoqifeng huoqifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huoqifeng huoqifeng merged commit cc1b7e4 into confidential-containers:main Jan 4, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants