-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: Add support for pods' secure communication #1663
Merged
liudalibj
merged 1 commit into
confidential-containers:main
from
wyuany:e2e-support-https-service
Jan 18, 2024
Merged
e2e: Add support for pods' secure communication #1663
liudalibj
merged 1 commit into
confidential-containers:main
from
wyuany:e2e-support-https-service
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyuany
force-pushed
the
e2e-support-https-service
branch
from
January 15, 2024 06:54
a9797e9
to
38100a5
Compare
liudalibj
reviewed
Jan 15, 2024
liudalibj
reviewed
Jan 15, 2024
wyuany
force-pushed
the
e2e-support-https-service
branch
from
January 16, 2024 01:24
38100a5
to
5d9e3cb
Compare
huoqifeng
reviewed
Jan 16, 2024
wyuany
force-pushed
the
e2e-support-https-service
branch
from
January 16, 2024 03:50
5d9e3cb
to
e8fb4f2
Compare
huoqifeng
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
liudalibj
reviewed
Jan 16, 2024
test/e2e/libvirt_test.go
Outdated
@@ -91,3 +92,10 @@ func TestLibvirtPodToServiceCommunication(t *testing.T) { | |||
assert := LibvirtAssert{} | |||
DoTestPodToServiceCommunication(t, testEnv, assert) | |||
} | |||
|
|||
func TestLibvirtPodsMTLSCommunication(t *testing.T) { | |||
assert := IBMCloudAssert{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here should be
assert := LibvirtAssert{}
wyuany
force-pushed
the
e2e-support-https-service
branch
from
January 17, 2024 04:20
e8fb4f2
to
b58e421
Compare
Export secure port and extra secret for pods' secure communication fix: confidential-containers#1658 Signed-off-by: Yuan Yuan Wang <wyuany@cn.ibm.com>
wyuany
force-pushed
the
e2e-support-https-service
branch
from
January 17, 2024 05:01
b58e421
to
948d2f2
Compare
liudalibj
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export secure port and extra secret for pods' secure communication
fix: #1658