Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Add support for pods' secure communication #1663

Merged

Conversation

wyuany
Copy link
Contributor

@wyuany wyuany commented Jan 15, 2024

Export secure port and extra secret for pods' secure communication

fix: #1658

test/e2e/common.go Outdated Show resolved Hide resolved
test/e2e/assessment_runner.go Outdated Show resolved Hide resolved
test/e2e/assessment_runner.go Outdated Show resolved Hide resolved
@liudalibj liudalibj added the test_e2e_libvirt Run Libvirt e2e tests label Jan 16, 2024
Copy link
Contributor

@huoqifeng huoqifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -91,3 +92,10 @@ func TestLibvirtPodToServiceCommunication(t *testing.T) {
assert := LibvirtAssert{}
DoTestPodToServiceCommunication(t, testEnv, assert)
}

func TestLibvirtPodsMTLSCommunication(t *testing.T) {
assert := IBMCloudAssert{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here should be

assert := LibvirtAssert{}

Export secure port and extra secret for pods' secure communication

fix: confidential-containers#1658

Signed-off-by: Yuan Yuan Wang <wyuany@cn.ibm.com>
Copy link
Member

@liudalibj liudalibj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liudalibj liudalibj merged commit 5a725b0 into confidential-containers:main Jan 18, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test_e2e_libvirt Run Libvirt e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e: add support for multiple pods communication with https connection.
3 participants