Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes #1664

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Misc fixes #1664

merged 2 commits into from
Jan 19, 2024

Conversation

bpradipt
Copy link
Member

  1. Set default nvidia driver version
  2. Update example in AWS README

Copy link
Contributor

@snir911 snir911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, see comment

podvm/addons/nvidia_gpu/setup.sh Outdated Show resolved Hide resolved
Set default to 535, the latest version and also do some minor
cleanups of the install script

Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
The example deployment yaml didn't had the annotation in the
correct location

Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Copy link
Member

@beraldoleal beraldoleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bpradipt bpradipt merged commit 52237c5 into confidential-containers:main Jan 19, 2024
18 checks passed
@bpradipt bpradipt deleted the nvidia-driver branch January 19, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants