install: Deploy peerpod-ctrl by default

[bpradipt]

The default value of RESOURCE_CTRL is set to true to allow deletion of dangling resources.

[huoqifeng]

LGTM

[huoqifeng]

Thank you @bpradipt

[stevenhorsman]

Do we need to some something to make the e2e tests also deploy the peerpod-ctrl?
Maybe after

cloud-api-adaptor/test/provisioner/provision.go

Lines 218 to 221 in 827d0f1

	log.Info("Install the cloud-api-adaptor")
	if err := p.installOverlay.Apply(ctx, cfg); err != nil {
	return err
	}

? I want to avoid us having different default config in the CI tests from the other deployment approach(es).

Maybe we should add a line to the manual install path of the readme as well to tie up those loose ends?

[bpradipt]

Do we need to some something to make the e2e tests also deploy the peerpod-ctrl? Maybe after

cloud-api-adaptor/test/provisioner/provision.go

Lines 218 to 221 in 827d0f1

	log.Info("Install the cloud-api-adaptor")
	if err := p.installOverlay.Apply(ctx, cfg); err != nil {
	return err
	}

? I want to avoid us having different default config in the CI tests from the other deployment approach(es).
Maybe we should add a line to the manual install path of the readme as well to tie up those loose ends?

Yeah good point. I'll look into how to enable it in e2e by default

[stevenhorsman]

The provisioning update code looks okay to me. Sorry to be a pain, but should we consider running peerpod-ctrl undeploy somewhere around

cloud-api-adaptor/test/provisioner/provision.go

Line 132 in 1b21353

ccPods, err := GetDaemonSetOwnedPods(ctx, cfg, p.ccDaemonSet)

?

[stevenhorsman]

Code LGTM, so as long as the e2e libvirt tests pass, I'm happy for this to be merged. Thanks @bpradipt for the code and updates.

[stevenhorsman]

The e2e tests are failing with:

Traceback (most recent call last):
  File "/usr/bin/kcli", line 33, in <module>
    sys.exit(load_entry_point('kcli==99.0', 'console_scripts', 'kcli')())
  File "/usr/lib/python3/dist-packages/kvirt/cli.py", line 5416, in cli
    args.func(args)
  File "/usr/lib/python3/dist-packages/kvirt/cli.py", line 131, in get_version
    git_version, git_date = get_git_version()
  File "/usr/lib/python3/dist-packages/kvirt/common/__init__.py", line [21](https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/7570170726/job/20616589992?pr=1665#step:10:22)14, in get_git_version
    git_version, git_date = open(git_file).read().rstrip().split(' ')

this looks like the same issue that @karmab fixed a couple of weeks ago, though 😕

[wainersm]

hi @bpradipt !

In order to test peerpod-ctrl changes on pull request you will need to build and push its image like we do for podvm and cloud-api-adaptor images. Otherwise it will be testing quay.io/confidential-containers/peerpod-ctrl:latest, that is published on every merge.

[karmab]

The e2e tests are failing with:

Traceback (most recent call last):
  File "/usr/bin/kcli", line 33, in <module>
    sys.exit(load_entry_point('kcli==99.0', 'console_scripts', 'kcli')())
  File "/usr/lib/python3/dist-packages/kvirt/cli.py", line 5416, in cli
    args.func(args)
  File "/usr/lib/python3/dist-packages/kvirt/cli.py", line 131, in get_version
    git_version, git_date = get_git_version()
  File "/usr/lib/python3/dist-packages/kvirt/common/__init__.py", line [21](https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/7570170726/job/20616589992?pr=1665#step:10:22)14, in get_git_version
    git_version, git_date = open(git_file).read().rstrip().split(' ')

this looks like the same issue that @karmab fixed a couple of weeks ago, though 😕

let me check

[bpradipt]

hi @bpradipt !

In order to test peerpod-ctrl changes on pull request you will need to build and push its image like we do for podvm and cloud-api-adaptor images. Otherwise it will be testing quay.io/confidential-containers/peerpod-ctrl:latest, that is published on every merge.

@wainersm that's not the intent and frankly out of scope for this PR. peerpod-ctrl is treated like the operator here.
Sometime back we had a discussion to move out peerpod-ctrl and peerpodconfig-ctrl to it's own repos to make it easier for testing.

[wainersm]

hi @bpradipt !
In order to test peerpod-ctrl changes on pull request you will need to build and push its image like we do for podvm and cloud-api-adaptor images. Otherwise it will be testing quay.io/confidential-containers/peerpod-ctrl:latest, that is published on every merge.

@wainersm that's not the intent and frankly out of scope for this PR. peerpod-ctrl is treated like the operator here. Sometime back we had a discussion to move out peerpod-ctrl and peerpodconfig-ctrl to it's own repos to make it easier for testing.

Alright, thanks for the explanation!

[karmab]

the issue is that github change again their commits page format (with no mention nowhere...), so I fixed it with https://github.com/karmab/kcli/actions/runs/7573926453 so that

• git ls-remote is used to populate the version instead
• if the version file is incorrectly formatted, no exception is thrown