Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: remove redundant aws-region flag on cloud-api-adaptor invocation #1670

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

EmmEff
Copy link
Contributor

@EmmEff EmmEff commented Jan 19, 2024

Remove redundant -aws-region argument.

This arg is processed in the code:

[[ "${AWS_REGION}" ]] && optionals+="-aws-region ${AWS_REGION} " # if not set retrieved from IMDS

This argument is (also) passed with an empty value if AWS_REGION is not specified.

Argument '-aws-region' is optionally added to args if specified.

Signed-off-by: Mike Frisch <mikef17@gmail.com>
@EmmEff EmmEff changed the title aws-updates aws: remove redundant aws-region flag on cloud-api-adaptor invocation Jan 19, 2024
@bpradipt bpradipt requested a review from snir911 January 20, 2024 04:17
Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@snir911 snir911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@snir911 snir911 merged commit b45d525 into confidential-containers:main Jan 21, 2024
18 checks passed
@EmmEff EmmEff deleted the aws-updates branch January 21, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants