libvirt: update scripts for libvirt

[liudalibj]

• check golang version, the installed golang version must >= the value from versions.yaml
• update two default values in install_operator.sh

[stevenhorsman]

Thanks for the update. I've tested this with a number of different scenarios:

• We already have the same version of go installed as the versions.yaml:

# go version
go version go1.20.12 linux/amd64
root@dali-config-libvirt-go-test1:~/cloud-api-adaptor# ./libvirt/config_libvirt.sh
Installing Go...
Found 1.20.12 at /usr/local/go, good to go

• We have a newer patch release:

# go version
go version go1.20.13 linux/amd64
root@dali-config-libvirt-go-test1:~/cloud-api-adaptor# ./libvirt/config_libvirt.sh
Installing Go...
Found 1.20.13 at /usr/local/go, good to go

• We have a newer minor version:

go version go1.21.6 linux/amd64
# ./libvirt/config_libvirt.sh
Installing Go...
Found 1.21.6 at /usr/local/go, good to go

• We have an older minor version:

go version go1.18.10 linux/amd64
# ./libvirt/config_libvirt.sh
Installing Go...
Warning: Found 1.18.10 at /usr/local/go, is lower than our required 1.20.12
Please run "rm -rf /usr/local/go" and run this script again.
root@dali-config-libvirt-go-test1:~/cloud-api-adaptor# rm -rf /usr/local/go
root@dali-config-libvirt-go-test1:~/cloud-api-adaptor# ./libvirt/config_libvirt.sh
Installing Go...
Installed golang with 1.20.12
root@dali-config-libvirt-go-test1:~/cloud-api-adaptor# go version
go version go1.20.12 linux/amd64

• We have an older patch version:

# go version
go version go1.20.10 linux/amd64
root@dali-config-libvirt-go-test1:~/cloud-api-adaptor# ./libvirt/config_libvirt.sh
Installing Go...
Warning: Found 1.20.10 at /usr/local/go, is lower than our required 1.20.12
Please run "rm -rf /usr/local/go" and run this script again.
root@dali-config-libvirt-go-test1:~/cloud-api-adaptor# rm -rf /usr/local/go
root@dali-config-libvirt-go-test1:~/cloud-api-adaptor# ./libvirt/config_libvirt.sh
Installing Go...
Installed golang with 1.20.12

and all worked as expected! Thanks @liudalibj!

[huoqifeng]

Did a rough testing, it looks good:

root@c37646v1:~# export installed_go_version=1.18.10
root@c37646v1:~# ret=$(printf '%s\n' "$REQUIRED_GO_VERSION" "$installed_go_version" | sort -V | head -1)
root@c37646v1:~# echo $ret

root@c37646v1:~# export REQUIRED_GO_VERSION=1.20.12
root@c37646v1:~# 
root@c37646v1:~# 
root@c37646v1:~# ret=$(printf '%s\n' "$REQUIRED_GO_VERSION" "$installed_go_version" | sort -V | head -1)
root@c37646v1:~# echo $ret
1.18.10
root@c37646v1:~# export installed_go_version=1.20.12
root@c37646v1:~# ret=$(printf '%s\n' "$REQUIRED_GO_VERSION" "$installed_go_version" | sort -V | head -1)
root@c37646v1:~# echo $ret
1.20.12
root@c37646v1:~# export installed_go_version=1.20.13
root@c37646v1:~# ret=$(printf '%s\n' "$REQUIRED_GO_VERSION" "$installed_go_version" | sort -V | head -1)
root@c37646v1:~# echo $ret
1.20.12
root@c37646v1:~# export installed_go_version=1.21.10
root@c37646v1:~# ret=$(printf '%s\n' "$REQUIRED_GO_VERSION" "$installed_go_version" | sort -V | head -1)
root@c37646v1:~# echo $ret
1.20.12

[huoqifeng]

LGTM

[huoqifeng]

Another thing I remembered but might be wrong, @lysliu tried to build caa against golang 1.21.x but failed. @liudalibj

[liudalibj]

Another thing I remembered but might be wrong, @lysliu tried to build caa against golang 1.21.x but failed. @liudalibj

It's different issue, I didn't change the go version in go.mod for caa.
Here the config_libvirt.sh is used to config libvirt dev/test env, I tried in my dev machine,

• I install golang 1.21.2
• run make test-e2e for libvirt
  The e2e test are passed with good result with the installed golang 1.21.2