Misc fixes #1686
Merged
Misc fixes #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bpradipt
commented
Feb 3, 2024
bpradipt
commented
- The provisioning command used a wrong ordering of daemonconfig and authJson files, resulting in startup errors for process-user-data
- Change AWS default instance type to CVM to align with the default disable-cvm option
- Fix handling of describeimages
Change the ordering of members in the Config struct to match the input invocation using NewConfig. Also include a minor fix to the error string Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
This is to align with disable-cvm default which is set to false. The default instance type is now a CVM. Additionally remove code that's not required Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Handle null or empty describeImagesOuput Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
snir911
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.