Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-image-build: Add missing pre-reqs #1699

Conversation

surajssd
Copy link
Member

Azure image build documentation was missing a bunch of prerequisites. This commit adds them explicitly.


Tested these instructions in an ubuntu container.

@surajssd surajssd marked this pull request as ready for review February 18, 2024 03:04
azure/build-image.md Outdated Show resolved Hide resolved
azure/build-image.md Show resolved Hide resolved
Azure image build documentation was missing a
bunch of prerequisites. This commit adds them
explicitly.

Signed-off-by: Suraj Deshmukh <suraj.deshmukh@microsoft.com>
@surajssd surajssd force-pushed the azure-image-build-improve-docs branch from 8c820dc to f51624d Compare February 20, 2024 02:03
@surajssd surajssd requested a review from mkulke February 20, 2024 02:04
Copy link
Contributor

@kartikjoshi21 kartikjoshi21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kartikjoshi21 kartikjoshi21 merged commit 3f8bbf5 into confidential-containers:main Feb 22, 2024
18 checks passed
@surajssd surajssd deleted the azure-image-build-improve-docs branch February 23, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants